This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: add partial implementation for ipfs.resolve #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Jul 23, 2018
Closed
alanshaw
changed the title
alanshaw
force-pushed
the
feat/resolve
branch
2 times, most recently
from
7f3c599
to
7273bff
Compare
daviddias
approved these changes
Aug 9, 2018
alanshaw
force-pushed
the
feat/resolve
branch
2 times, most recently
from
2d43474
to
a023218
Compare
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
daviddias
approved these changes
Aug 22, 2018
|
ah, I was pausing on merging these 0.32 PRs until I was able to merge #1523 and do another 0.31 patch release... 🙄 😆 |
|
Oh, sorry about that. I didn't see a breaking change note :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a partial implementation for
ipfs.resolve- we can resolve:/ipfs/QmRootHash/path/to/fileto/ipfs/QmFileHashResolving IPNS paths will callback with a not implemented error.
Allows the following tests from ipfs-inactive/interface-js-ipfs-core#332 to pass:
depends on
ipfs-inactive/interface-js-ipfs-core#332,ipfs-inactive/js-ipfs-http-client#794,ipld/js-ipld-dag-pb#78andipfs/js-ipfsd-ctl#285